Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

On Tue, Dec 07, 2010 at 12:39:19PM +0000, Michael Meeks wrote:
> Hi David,
>
> On Tue, 2010-12-07 at 10:54 +0100, David Tardon wrote:
> > > I think the simplest thing here is to run SessionManagerClient::open
> > > when initializing the quickstarter (the function is exported, so there
> > > should be no problem with that), but there might be a cleaner solution.
> >
> > What if we do this when SalSession is created? Does anyone see any
> > problem with that approach ?
>
>       There are some potential risks here; we don't want to do this if we are
> just going to push our arguments off to another process or before we
> start the splash (that is prolly the legacy explanation for deferring it
> - since it is a set of synchronous calls AFAICS).
>
>       Luckily the new standalone unix splash / quick-starter handles both of
> these before we even start, and deprecates those concerns, so I suspect
> there is no issue here. Having said that - this is another miracle of
> UNO-isation - with the SessionManagerClient stuff being instantiated in
> framework/ via a service, which itself is (presuambly) instantiated via
> another service etc. etc. - making the code not only slower, but far
> more difficult to follow :-)

Yeah, that one is created as com.sun.star.frame.SessionListener service
in desktop::Desktop::OpenClients :-)

>       So - anyhow, I'd say whack the patch in, and hopefully it will solve
> your abrt issues in an elegant way :-)

Okay, pushing.

D.