Re: [Libreoffice] [PUSHED][PATCH] RTL_CONSTASCII_USTRINGPARAM for dbaccess/source/ui/dlg

Noel Power <nopower -AT- novell.com>
Tue, 07 Dec 2010 12:53:20 +0000

Hi Julien
On 06/12/10 21:40, Julien Nabet wrote:

Hello,

Here's a small patch for dbaccess/source/ui/dlg

This is a strange one, it seems SERVICE_UI_FOLDERPICKER is not a simpleconst char but an instance of ConstAsciiString ( defined indbaccess/source/inc/constasciistring.hxx ) so I changed the patch as follows

- ::rtl::OUString sFolderPickerService =::rtl::OUString::createFromAscii(SERVICE_UI_FOLDERPICKER);+ ::rtl::OUStringsFolderPickerService(SERVICE_UI_FOLDERPICKER);

it seems that there is already an operator to return an OUString& .Caolan, this is a new one on me, you seen it before? Does that look likewe might have problems if we converted similar definitions aspresumeably RTL_CONSTASCII_USTRINGPARAM would try to take sizeof(ConstAsciiString ) in that case


I committed the variation above


Noel

Context

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for dbaccess/source/ui/dlg · Julien Nabet
- Re: [Libreoffice] [PUSHED][PATCH] RTL_CONSTASCII_USTRINGPARAM for dbaccess/source/ui/dlg · Noel Power
  - Re: [Libreoffice] [PUSHED][PATCH] RTL_CONSTASCII_USTRINGPARAM for dbaccess/source/ui/dlg · Caolán McNamara
    - [Libreoffice] compile time verification of SAL_N_ELEMENTS and STRING_CONST foo · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.