Hi Takeshi,
On Fri, 2010-11-26 at 01:48 +0900, Takeshi Abe wrote:
yet another cleanup on base.
Great to see you fixing English spellings :-)
switch( nColId )
{
//////////////////////////////////////////////////////////////
- // NameCell
- case FIELD_NAME:
- {
- // removed the former duplicate-check. this is done in
OTableDocShell::CheckDefConsistency now.
- // FS - 07.12.99 - 69575
-
- } break;
By removing this case statement, we could change the control flow of
course - so FIELD_NAME will go through to a default statement, but in
this case - the is none - so it's fine :-)
case FIELD_PROPERTY_NUMTYPE:
OSL_ENSURE(sal_False, "OTableEditorCtrl::GetCellData: invalid column!");
- // return pFieldDescr->GetNumType();
+ break;
This again looks like an inadvertent drop-through; though presumably
~never called.
- } // if(!_bSet && _pFieldDesc->getTypeInfo()->bNullable)
+ }
Odd isn't it :-)
This is some lovely work - thanks !
Pushed,
Michael.
--
michael.meeks@novell.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.