Re: [Libreoffice] Auto-detection of toolbar icon size (well, kinda)

Michael Meeks wrote:
> > prompted by some complaints on too large icons on Mac, switched the
> > icon size from 'large' to 'auto' for 3.3.
>
>       Did we ever get some screenshots of the perceived problem ? I asked in
> some bug, but never got that back AFAIR.
Hi Michael,

take my word for it, it looks out-of-place on Mac.

>       My concern is for Windows really - I'd want the vast majority of users
> on > 1024x768 to have large icons.
>
>       Have we tested it there ?
Code on Win32 is currently:

long nHeightPx = aMenuFont.GetHeight() * nDPIY / 72;
aStyleSettings.SetToolbarIconSize( (((nHeightPx-1)*2) >= 28) ? STYLE_TOOLBAR_ICONSIZE_LARGE : 
STYLE_TOOLBAR_ICONSIZE_SMALL );

If that does not suffice, surely we can do a hard pick for _LARGE
here, just the same as for Gnome/KDE. It's the sole discretion of 
the native widget layer now - that's were it belongs to.

Cheers,

-- Thorsten

Attachment: pgphbJN1v5pbk.pgp
Description: PGP signature