Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


On Fri, 2010-11-19 at 12:09 -0800, Kayo Hamid wrote:
Sending for review. It covers source/filter/ dirs.



I kept stuff like
// 0.01mm = 0.57twip 
as that's a useful comment IMO

and I kept stuff like

 void SwHTMLParser::EndNumBulListItem( int nToken, sal_Bool bSetColl, 
-                                      sal_Bool /*bLastPara*/ ) 
+                                      sal_Bool ) 

as that's a common enough pattern which I don't have a problem with
where the argument is commented out to avoid a compiler warning when
someone has to override a method but doesn't need a particular argument
in the overridden method, and it helps comment what that other argument
is for.

Otherwise, happy with the rest of it and pushed it now. Thanks for this.

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.