[Libreoffice] [PUSHED] Re: [PATCH 12/12] RTL_CONSTASCII_USTRINGPARAM in components - xmlsecurity- helpd

Caolán McNamara <caolanm -AT- redhat.com>
Wed, 17 Nov 2010 16:43:17 +0000

On Tue, 2010-11-16 at 22:51 +0100, Pierre-André Jacquod wrote:

regards



Looks good, thanks for this. I pushed this, though with some slight
modifications. 

When I see
foo = rtl::OUString::createFromAscii("")
I think I prefer just
foo = rtl::OUString();
as the replacement. I reckon its simpler and more to the point.

C.

Context

[Libreoffice] [PUSHED] Re: [PATCH 08/12] RTL_CONSTASCII_USTRINGPARAM in components misc (continued)
- [Libreoffice] [PATCH 09/12] RTL_CONSTASCII_USTRINGPARAM in components - xstor · Pierre-André Jacquod
  - [Libreoffice] [PUSHED] Re: [PATCH 09/12] RTL_CONSTASCII_USTRINGPARAM in components - xstor · Caolán McNamara
- [Libreoffice] [PATCH 10/12] RTL_CONSTASCII_USTRINGPARAM components - zippackage · Pierre-André Jacquod
  - [Libreoffice] [PUSHED] Re: [PATCH 10/12] RTL_CONSTASCII_USTRINGPARAM components - zippackage · Caolán McNamara
- [Libreoffice] [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi · Pierre-André Jacquod
  - [Libreoffice] [PUSHED] Re: [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi · Caolán McNamara
    - Re: [Libreoffice] [PUSHED] Re: [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi · Pierre-André Jacquod
      - Re: [Libreoffice] [PUSHED] Re: [PATCH 11/12] RTL_CONSTASCII_USTRINGPARAM components - zipapi · Caolán McNamara
- [Libreoffice] [PATCH 12/12] RTL_CONSTASCII_USTRINGPARAM in components - xmlsecurity- helpd · Pierre-André Jacquod
  - [Libreoffice] [PUSHED] Re: [PATCH 12/12] RTL_CONSTASCII_USTRINGPARAM in components - xmlsecurity- helpd · Caolán McNamara
- [Libreoffice] [PUSHED] Re: [PATCH 01/12] RTL_CONSTASCII_USTRINGPARAM in components/cui/...option · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.