Re: [Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc (datefunc, analysis and solver)

keep up the good work julien :)

On Fri, Nov 12, 2010 at 4:01 PM, Kohei Yoshida <kyoshida@novell.com> wrote:

> Hi Julien,
>
> On Fri, 2010-11-12 at 14:02 +0100, Julien Nabet wrote:
> > Hello,
> >
> > Here's a patch for calc
>
> Applied and pushed.  Beautifully done. :-)
>
> > I think it's the last one for "calc" since i haven't seen other
> > "createFromAscii" to remove which concerned litterals.
> >
> > In datefunc, i tried to use the syntax :
> >
> > rtl::OUString foo(RTL_CONSTASCII_STRINGPARAM("foo"));
> >
> > -            OUString aImpl = OUString::createFromAscii( "/" );
> > +            OUString aImpl(RTL_CONSTASCII_USTRINGPARAM( "/" ));
> >
> > Hope it's ok and there wasn't other i missed.
>
> Yup, that's what we'd have expected.
>
> Thanks a lot, and keep them coming!
>
> Kohei
>
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
> <kyoshida@novell.com>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice



-- 
Jonathan Aquilina