Re: [Libreoffice] [PATCH] Test for KDE in configure.in

On 12/11/10 20:33, Rene Engelhard wrote:
> On Fri, Nov 12, 2010 at 08:25:49PM +0000, Wols Lists wrote:
> > It's not a complete patch, but it documents the requirements for KDE3,
> > and it adds a test for KDE4. The kde4 test doesn't (can't) easily test
> > for everything because libsolid doesn't seem to set up pkgconfig :-( but
> > at least we're trapping some of it.
> >
> > If somebody who has KDE3 can finish off the kde3 bit, that would be nice ...
> This is such icomplete that it shouldn't be merged. Besides that, there's a KDE
> check in the inner configure.in, and the build module is supposed to go away, so..
So we're ditching <loroot>configure.in? Fair enough. BUT.

It's just that, at present, if the system doesn't have kde4, then by
default it will crash at the "make" stage. This patch means that autogen
will fail with an error message. (And I can't easily test for libsolid,
because it doesn't create a pkgconfig file - at least it doesn't on my
gentoo system.) I would have thought bringing any failure forward was a
good thing?

I daren't actually do the test for kde3, because that might not create
pkgconfig files, and not having a kde3 system I can't quickly and easily
check whether the libs actually do.

Cheers,
Wol