Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java

Wols Lists <antlists -AT- youngman.org.uk>
Fri, 05 Nov 2010 09:43:07 +0000

On 05/11/10 07:42, Sebastian Spaeth wrote:

On Thu, 04 Nov 2010 18:24:04 +0000, Wols Lists  wrote:

+  --with-java             Build LibO with a JDK & Java support.],

So, what should be the default? Including Java? Then I would argue for
making this a --without option and having Java enabled by default... ?

I'll check to see what exactly is in the make system.  What I did was
look to see if enable-java was used anywhere (it isn't), and just change
it to with-java so the macro definition (a) matched the documentation,
and (b) matched what the rest of the build system used.

In other words, this patch is a "do nothing bug fix" and should be safe
"as is". Your suggestion is actually a functional change so yes, it
makes sense, but imho it should be a separate patch.

Cheers,
Wol

Context

[Libreoffice] [PATCH] Convert --enable-java to --with-java · Wols Lists
- Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java · Sebastian Spaeth
  - Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java · Wols Lists
  - Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java · Rene Engelhard
    - Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java · Wols Lists

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.