Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


On Mon, 2010-11-01 at 22:06 +0100, Marcin "eXine" M. wrote:

Looks mostly good, thanks for this. Just three little things

In cui/source/customize/cfgutil.cxx the body of
SfxConfigFunctionListBox_Impl::MouseMove was commented out, so you
removed the full method. That mightn't be the right thing to do as I
see that its a virtual method and so doing nothing is different to
defaulting to use the parent method. So I left the method in, but
removed its all-comments contents to make it empty.

I think you cut a little too deep in cui/source/dialogs/charmap.src.
There was an extra chunk between two comments which got deleted.

In cui/source/dialogs/linkdlg.cxx the comment
"UpdateTimer fuer DDE-/Grf-Links, auf die gewarted wird" was removed, so
I dropped that bit of the patch in the hope that someone can translate
it into english.

C. 


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.