Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


Hi Robert,

On Mon, 2010-11-01 at 20:26 +0200, Roth Robert wrote:
Attached you'll find 4 patches, colicensed with LGPLv3+, GPLv3+ and
MPL, with some bogus comments removed containing only changed date,
some commented lines removed, and some german comments translated.
I hope this is the right way to do it. Any feedback is appreciated.

        Really lovely work :-) thank you. A minor nit is that it can be worth
keeping issue numbers if they are available eg:

-        // --> OD 2004-06-30 #i28701# - page frame the object is registered at
+        // #i28701 - page frame the object is registered at

        can be better than:

-        // --> OD 2004-06-30 #i28701# - page frame the object is registered at
+        // page frame the object is registered at

        Clearly if there are tens of cut/paste references to the same bug in
the same function they serve no useful purpose really; so fair enough.

        And obviously #123456# comments are not worth saving - they are to an
internal Sun bug tracker we have no insight into.

        Otherwise - this is really nice. I've pushed them (with some tweaks to
retain a few interesting looking issue numbers ) to master.

        Thanks again,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.