[Libreoffice] [PUSHED] Re: [PUSHED, partially] Re: [PATCH] cppcheck "Common realloc mistake"

Caolán McNamara <caolanm -AT- redhat.com>
Mon, 01 Nov 2010 10:01:00 +0000

On Mon, 2010-11-01 at 09:02 +0100, Gert Faller wrote:

I was just wondering if freeing some bytes was worth while.
A patch for this...


re: realloc_patch_3.patch
Yeah, it's probably a bit expensive to realloc in order to drop a tiny
amount of bytes, but its an unlikely code path anyway so patch applied
and warning silenced :-). Pushed.

re: realloc_patch_4.patch
Tracing the logic, yes this look good. a failure on realloc will trundle
down past everything else and end up with a return false which is what
we want here. Pushed.

C.

Context

[Libreoffice] [PATCH] cppcheck "Common realloc mistake" · Gert Faller
- Re: [Libreoffice] [PATCH] cppcheck "Common realloc mistake" · Caolán McNamara
  - Re: [Libreoffice] [PATCH] cppcheck "Common realloc mistake" · Gert Faller
    - [Libreoffice] [PUSHED, partially] Re: [PATCH] cppcheck "Common realloc mistake" · Caolán McNamara
      - Re: [Libreoffice] [PUSHED, partially] Re: [PATCH] cppcheck "Common realloc mistake" · Gert Faller
        
        [Libreoffice] [PUSHED] Re: [PUSHED, partially] Re: [PATCH] cppcheck "Common realloc mistake" · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.