Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


On Sat, 2010-10-30 at 21:04 +0300, Jani Monoses wrote:
Just like the other .cxx files in starmath, make this one include 
unomodel.hxx and get the definition of the A2OU macro from there
instead of redefining it.

Doesn't hurt, so pushed, thanks.

Looking at the A2OU define I see that it's just
rtl::OUString::createFromAscii, so anyplace where A2OU is being used
with a string literal is also replaceable with the slightly faster
version, e.g.

foo = A2OU("string literal);
->
foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("string literal));

rtl::OUString aThing(A2OU("foo"));
->
rtl::OUString aThing(RTL_CONSTASCII_USTRINGPARAM("foo"));

with the same logic that foo = A2OU(pFoo); is not guaranteed replaceable
with the RTL_CONSTASCII_USTRINGPARAM macro.

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.