Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


On Sat, 2010-10-30 at 17:08 +0200, Gert Faller wrote:
Hi,
a first try on that.

Excellent, these are little mini-optimizations and they all help.

Not sure if I let the original source (for control)

Nah, don't bother keeping the old content as a comment, we can look at
the git history to see what it was previously if its necessary to do so.
So I stripped those from the patch.

You have two typos in there however, i.e.

- com.sun.star.chart.BarDiagram
+ com.sun.star.chart.BarDiagra

- com.sun.star.chart2.ScatterChartType
+ com.sun.star.chart2.ScatterChartTyp

in those two cases the trailing letter of the original string got
removed !, eek that was close ;-). So I fixed up those two and
committed and pushed this change. Thanks.

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.