On Mon, Oct 25, 2010 at 1:39 PM, Tor Lillqvist <tlillqvist@novell.com> wrote:
Isn't that wrong? Assuming there are non-Windows platforms where the bundled ICU is used (generic
Linux build, other Unixes?), previously that #include <iostream> has been used on all of them,
but after your change it will be used only on MSVC versions earlier than 10.
Or is that OK, is the <iostream> functionality actually needed in that source file just for those
earlier MSVC versions, but <iostream> has previously been included out of laziness on all
platforms?
Yes, the ifdef condition is wrong. I am not sure if the include is
needed in other platforms, but I guess most of them are using a system
icu instead of the old internal one.
--
Jesús Corrius <jesus@softcatala.org>
Document Foundation founding member
Skype: jcorrius | Twitter: @jcorrius
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.