Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE #3

Caolán McNamara <caolanm -AT- redhat.com>
Wed, 20 Oct 2010 16:10:09 +0100

On Mon, 2010-10-18 at 18:47 +0200, Jacek Wolszczak wrote:

Hi,

Another patch replacing DBG_ stuff with OSL_ equivalents.

Didn't know what to replace
http://opengrok.go-oo.org/xref/writer/sw/source/ui/dbui/dbinsdlg.cxx#1190 with.


I'm swayed towards OSL_ENSURE(false, "message"); for the general case.

I am not sure where changes in lines 3838-3857 in my patch come from.
Probably result from some changes introduced by other contributors in
the meantime. If so, please ignore this part of my patch.


I just chopped that bit out. And you accidentally removed a neccessary
"}" along the way, there was one OSl_ENSURE instead of OSL_ENSURE, and
another little gotcha here and there. Make sure you compile your changes
and that'll catch those :-)

Otherwise looks good, committed and pushed. Thanks.

C.

Context

[Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE #3 · Jacek Wolszczak
- Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE #3 · Caolán McNamara
  - Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE #3 · Jacek Wolszczak

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.