On Sat, 2010-10-16 at 01:01 +0200, Kenneth Venken wrote:
some "shadows a member of 'this'" and "unused parameter" warnings.
Great :-) though compile warnings in binfilter are less problematic
than elsewhere, since it is known-awful, legacy code that most people
don't use. But I've pushed it - thanks.
i've added an underscore prefix to the parameters that shadowed the
members. Are there any naming conventions i should know of?
That's fine.
what is the correct way to handle the "unused parameter" warnings?
In this case the whole function probably isn't used so i guess the
function could be removed?
Removing the parameters is great, and/or removing the function as you
suggest - perhaps Caolan's call-catcher doesn't catch un-used inline
functions so well; quite possibly remove & compile-testing them is a
good plan.
Thanks,
Michael.
--
michael.meeks@novell.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.