Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


On Mon, Oct 11, 2010 at 4:48 AM, Noel Power <nopower@novell.com> wrote:
Hi Ruben,

Thanks for hacking LibreOffice and thanks for the patch, it's mostly
committed,
On Sun, 2010-10-10 at 13:10 +0200, Rubén Jáñez wrote:
This patch removes bogus comments found in Base.
just be careful of removing any comment that reference openoffice
issuezilla bugs ( there is useful context there ) e.g. something like
"// #i15113#" the '#i' is normally indicative of an issuezilla bug
number. E.g. the previous example would have info like
http://qa.openoffice.org/issues/show_bug.cgi?id=15113
I've added some "GERMAN comments" to mark some comments because I don't know german
Ah nice idea but unfortunately I think it could really annoy others who
are already mid-way creating patches ( this would break their context )
Perhaps others might have a different opinion but anyway I didn't
include those hunks in the commit.

FWIW, that is why I didn't merge that one this WE. I agree with you,
but I wasn't sure...

Norbert


Anyway thanks again for the patch
( 
http://cgit.freedesktop.org/libreoffice/base/commit/?id=1362e62f0c9510d74e853ec26ff303b0223817f7 )

Noel

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.