Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


This patch closes a file that would be left open if memory allocation fails. 
The cppcheck error was [profile.c:248]: (error) Memory leak: pFile

Harri
diff --git a/sal/osl/unx/profile.c b/sal/osl/unx/profile.c
index 95e9606..cccf745 100644
--- a/sal/osl/unx/profile.c
+++ b/sal/osl/unx/profile.c
@@ -245,6 +245,7 @@ static oslProfile SAL_CALL osl_psz_openProfile(const sal_Char *pszProfileName, o
 
     if ( pProfile == 0 )
     {
+        closeFileImpl(pFile, Flags);
         return 0;
     }
 

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.