On Wed, 2010-10-06 at 23:51 +0100, jgraeme wrote:
On 6 October 2010 08:37, David Tardon <dtardon@redhat.com> wrote:
Some really rare stuff in here, like includes from sj2 or so3 :) Pushed.
Thanks for committing this patch, however when looking at
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=2ff212ff7de4675deeab61a3b68067de30589ff2
I noticed that unlike the other patches I've submitted I'm not down as
the author. Just checking to see if this actually matters or not?
Yeah, I think we the commiters should try to be aware that, when
applying patches from someone else we should use --author="...", to
honor the patch submitter. Better yet, since your patch is generated
with 'git format-patch', we can simply apply it with 'git am' which
automatically apply the correct author information. I've been using
that command to apply your patches as well as some of the others.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.