Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


Hi Phil,

Many thanks for getting involved in LibreOffice development adventure!

On Thu, 2010-09-30 at 10:54 -0500, Phil Bordelon wrote:
Folks,

Here are two patches for Writer/StarMath's accessibility.cxx.  (I
picked a random module and went for the first C++ file I could find
within.) One patch simply removes a whole bunch of dead code from
conditionals; the other is actually a minor bugfix, wherein someone
commented out a null-pointer check where they almost certainly just
meant to remove a refcounter.

It seems Ok for me.

I was wondering just how broad this patches should be; I have one that
removes a lot more dead code from accessibility.cxx, but should it also
do the same to the .hxx?  Other files at the same time?

Do as you like!

These patches are released under the GPLv3+, if that's relevant for
something so basic.

Thanks for your patches, but we can't integrate them unless you accept
to release them under the LGPLv3+.

Regards,

--
Cedric




Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.