Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


Hi Nick,

        This is some great work :-) but as cedric says being a bit more
discriminating would be good; ie. if the comment has something useful to
say lets keep just the useful bit:

On Tue, 2010-09-28 at 16:06 -0400, Nick Savage wrote:
I wasn't sure if this is what I was supposed to be doing, so I only
did that one folder. I'd like to be helping out LibreOffice any way I
can!

        Wise - and it's really good to have you on-board.

 
-// OD 20.02.2003 #107369# - method to update statics for paint
+// method to update statics for paint

        excellent :-)

-    // OD 2004-03-05 #i18143#
     mbBookPreview = false;
     mbBookPreviewModeToggled = false;

        Perhaps keeping the issue number - perhaps saving some vspace b
appending it to the next line ?
 
-/** calculate page preview layout sizes
-
-    OD 18.12.2002 #103492#
-
-    @author OD
-*/
 void SwPagePreviewLayout::_CalcPrevwLayoutSizes()

        Fair enough - we don't need to be told that CalcPrevwLayoutSizes
calculates page preview layout sizes ;-)

-        // OD 19.02.2003 #107369# - use method <GetRowOfPage(..)>.

        But that has some useful signal amid the noise to keep.

-/** method to adjust page preview layout to document changes
-
-    OD 18.12.2002 #103492#
-
-    @author OD
-*/
 bool SwPagePreviewLayout::ReInit()

        And the 'method to adjust ...' seems to add something useful
to ::Reinit ?

        Sorry the task was under-clear ? :-) any chance you could tweak the
task description to make it clearer in the wiki ? [ and do you want to
tweak the patch to get it included, or shall I ? ]

        Many thanks,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.