Re: [Libreoffice] easy hacks

Hi Jacopo,

thanks for the patch, just a couple of things, I'd like to preserve the
debug output
could you instead uncomment the debug lines and instead surround them
with a preprocessor conditional
e.g.

instead of 
                Type ret = mModuleBuilder.GetType (args.Name, false);
-               //Console.WriteLine ("mModuleBuilder.GetType yields
{0}", ret);
 
do
                Type ret = mModuleBuilder.GetType (args.Name, false);
-               //Console.WriteLine ("mModuleBuilder.GetType yields
{0}", ret);
+               if ( DEBUG )
+                    Console.WriteLine ("mModuleBuilder.GetType
yields ....


also be careful of removing (maybe?) useful comments like below

-                       code.Emit (OpCodes.Ldarg_0); // push this
+                       code.Emit (OpCodes.Ldarg_0);

and

                        ilGen.Emit (OpCodes.Newobj,
ctorDeploymentException);
-                       ilGen.Emit
(OpCodes.Throw); //Exception(typeDeploymentExc);
+                       ilGen.Emit (OpCodes.Throw);

etc.

Please don't be discouraged and give it another whirl
Thanks,

Noel
On Wed, 2010-09-29 at 22:38 +0200, Jacopo Nespolo wrote:
> Hi All,
> I tried to do what you are asking people to help doing. I checked the
> comments in
>
> /home/jacopo/Desktop/LibreOffice/build/patches/mono/climaker_csharp.cs
>
> cleaned up a bit, and then issued a git diff on that file.
> The output is in the attachment.
> Please tell me if this is the way you want us to proceed, or how I
> should do the job if it wasn't correct.
>
> In any case, thanks for the job you guys do.
> Jacopo
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice