[Libreoffice] [PATCH] Refactor to make cppcheck happy

[EDIT: Posting this again because the archive makes it look like it got
garbled.]

From the 'easy hacks' page it seemed that getting rid of warnings and flags
by tools like cppcheck was a goal.

Attached is a small patch that does nothing except eliminate one cppcheck
warning.  It is contributed under the LGPL3+.

As I said, it does nothing different and, depending on the compiler, it
could even be less efficient.  It does however make cppcheck happy.

Is this kind of thing useful?

diff --git a/soltools/javadep/javadep.c b/soltools/javadep/javadep.c
index d6dc580..6958f88 100644
--- a/soltools/javadep/javadep.c
+++ b/soltools/javadep/javadep.c
@@ -603,9 +603,11 @@ xcalloc(size_t nmemb, size_t size)
 void *
 xrealloc(void *ptr, size_t size)
 {
-    ptr = realloc(ptr, size);
+    void *newptr = realloc(ptr, size);
     
-    if ( !ptr )
+    if (!newptr)
+       ptr = newptr;
+    else
         err_quit("out of memory");
 
     return ptr;