On Tue, 2010-09-28 at 17:37 +0200, Sebastian Spaeth wrote:
This is a switch statement that only ever checks 1 case and has no
default action, so make it an if().
Remove some commented out code in the switch while taking the git
blame anyway.
Looks good, there is the theoretical possibility that the SfxAllItemSet
ctor which used to always get executed, but is now only executed under
that single condition, has some hidden sideeffects which would cause
some knock on. But that's exceedingly unlikely, I'd fire it in.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.